Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the minimum supported node.js version to the support page #1733

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

Phillip9587
Copy link
Contributor

@Phillip9587 Phillip9587 commented Jan 14, 2025

Added the minimum supported node.js version to the support page. Please correct me if I'm wrong about the minimum versions for the 3.x, 2.x, 1.x and 0.14.x release lines.

Preview: https://deploy-preview-1733--expressjscom-preview.netlify.app/en/support/

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 4f00733
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/6787e7ab7f22260008f70de5
😎 Deploy Preview https://deploy-preview-1733--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas requested review from a team January 14, 2025 21:13
Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, I support this addition. I have not confirmed the actual version numbers for EOL, but LGTM

de/support/index.md Outdated Show resolved Hide resolved
| **v0.14.x**{: .eol } | December 2010 | December 2010 |
| Major Version | Minimum Node.js Version | Support Start Date | Support End Date |
| -- | -- | -- | -- |
| [**v5.x**{: .supported }](/{{page.lang}}/5x/api.html) | 18.0.0 | September 2024 | **ongoing**{: .supported } |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it funny to anyone else that we called this translated but it is not? Why even have this copy instead of just falling back to the english version if it is just english anyway?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done this way because it's how translations work on the page. If we redirected to the English page, we would make the user click again to return to the language they were in before. There is a lot of improvement in the translation process.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and I agree this would be awesome to improve upon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The easiest way is to migrate to a more modern technology like starlight or docusaurus, which have better support for i18n and we wouldn't have to be copying the content like we're doing now, or a slightly more complicated approach would be to have the translations done by an AI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docusaurus gets my vote.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some very promising tools out there to translate the content with AI. If you are interested take a look at for example: https://github.com/midday-ai/languine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phillip9587, there is an issue about that, in case you want to participate,

and for the website migration, there is this issue.

@bjohansebas bjohansebas merged commit 743ccef into expressjs:gh-pages Jan 16, 2025
12 checks passed
@bjohansebas
Copy link
Member

@Phillip9587 thanks

@Phillip9587 Phillip9587 deleted the support-table-nodejs branch January 16, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants