Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert WolfSSL Poly1305 PR #203

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

kp-thomas-yau
Copy link
Contributor

@kp-thomas-yau kp-thomas-yau commented Dec 4, 2024

This patch reverts wolfSSL/wolfssl#7859 PR as WolfSSL 5.7.4 currently breaks ChaCha20 TCP connection from an Apple M1 Client in one of our coverage test in our lightway-core library. It turns out the PR causes "MAC did not match" in the server-side, which means the tag (used for authenticating the cipher-text) generated in the client-side is incorrect.

This new patch has already been applied to lightway-core library as well since this issue is occuring in WolfSSL 5.7.4 release.

This patch reverts https://github.com/wolfSSL/wolfssl/pull/7859/files PR as it currently breaks ChaCha20 TCP connection with ARM64/AArch64 client.
@kp-thomas-yau kp-thomas-yau changed the title Fix WolfSSL ChaCha20 TCP connection Revert WolfSSL Poly1305 PR Dec 4, 2024
@kp-thomas-yau kp-thomas-yau marked this pull request as ready for review December 4, 2024 03:54
@kp-thomas-yau kp-thomas-yau requested a review from a team as a code owner December 4, 2024 03:54
Copy link

github-actions bot commented Dec 4, 2024

Code coverage summary for 9dc0d33:

Filename                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
wolfssl-sys/src/lib.rs                     6                 0   100.00%           3                 0   100.00%          24                 0   100.00%           0                 0         -
wolfssl/src/chacha20_poly1305.rs          14                 2    85.71%           5                 0   100.00%          95                 2    97.89%           0                 0         -
wolfssl/src/context.rs                   172                83    51.74%          45                14    68.89%         344               131    61.92%           0                 0         -
wolfssl/src/error.rs                      19                 7    63.16%           5                 1    80.00%          51                 9    82.35%           0                 0         -
wolfssl/src/lib.rs                        68                14    79.41%          14                 2    85.71%          84                15    82.14%           0                 0         -
wolfssl/src/rng.rs                        19                 5    73.68%           4                 0   100.00%          47                 3    93.62%           0                 0         -
wolfssl/src/ssl.rs                       471               202    57.11%          80                24    70.00%        1060               276    73.96%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    769               313    59.30%         156                41    73.72%        1705               436    74.43%           0                 0         -

✅ Region coverage 59% passes
✅ Line coverage 74% passes

@kp-thomas-yau kp-thomas-yau merged commit 759ae86 into main Dec 4, 2024
8 checks passed
@kp-thomas-yau kp-thomas-yau deleted the revert-wolfssl-poly1305-pr branch December 4, 2024 05:22
kp-thomas-yau added a commit that referenced this pull request Dec 12, 2024
Apply the wolfSSL/wolfssl#8275 PR fix. The original revert patch was here to fix mismatched tag when we are using ChaCha20 in TCP connection. See #203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants