Dispose renderer when DrawingView is deinit. #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw that a lot of memory is leaked when creating
SVGViewthis way:SVGView(node: try! SVGParser.parse(text: path), frame: CGRect())I did some debugging and I think I found the issue.
DrawingViewis not disposing its renderer when it's deinit and so it's leaked. This PR fixes that.Another way this leaks could be solved (and probably should be to avoid future leaks) is to make
animationObserverson aNodea weak array so that it doesn't retain its observers.It's a little bit of extra work but maybe someone will find some time to implement it.
Cheers.