Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #766 SVGParser will parse the class attribute as Node Tag. #787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ty0x2333
Copy link

@ty0x2333 ty0x2333 commented Mar 7, 2022

I use Macaw for SVG rendering.

I have the same problem as #766

I need to dynamically modify the style by class. But there is no way to get nodes by class.

SVGParser currently only parses id as a Node Tag. This Pull Request parses class as a Node Tag as well.

This way, the node of the specified class can be found by the node.nodesBy(tag:) method without breaking the original design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant