Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-compiling: Update libz-sys to 1.1.20 #1226

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix cross-compiling: Update libz-sys to 1.1.20 #1226

merged 1 commit into from
Nov 14, 2024

Conversation

dbast
Copy link
Contributor

@dbast dbast commented Nov 11, 2024 •
edited
Loading

Fixes cross-compiling to osx-arm64 with gcc 18.

Done via: cargo update libz-sys

See also:

@dbast dbast requested a review from cafkafk as a code owner November 11, 2024 13:35
@dbast dbast mentioned this pull request Nov 11, 2024
Merged
5 tasks
@dbast
fix: Cross-compiling by updating to libz-sys to 1.1.20
7f6bd0c 
cross-compiling to osx-arm64 otherwise fails with gcc 18.
cafkafk
cafkafk approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty :p

@cafkafk cafkafk merged commit 4250d34 into eza-community:main Nov 14, 2024
20 checks passed
@dbast dbast mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafkafk cafkafk cafkafk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Eza Pull-Requests
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbast @cafkafk