[#11] JWT 설정 #13
Merged
[#11] JWT 설정 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
reviewed
Jan 8, 2025
| // URL별 권한 설정 | ||
| .authorizeHttpRequests(auth -> auth | ||
| .requestMatchers("/h2-console/**").permitAll() | ||
| .requestMatchers("/api/users/**").permitAll() |
There was a problem hiding this comment.
이렇게 하면, get users할때도 토큰이 필요없는거 아닐까요?
f-lab-lyan
reviewed
Jan 8, 2025
|
|
||
| @Component | ||
| public class JwtTokenProvider { | ||
| @Value("${jwt.secret-key}") |
f-lab-lyan
reviewed
Jan 8, 2025
| // Refresh Token 생성 | ||
| public String generateRefreshToken(String email) { | ||
| Date now = new Date(); | ||
| Date expiry = new Date(now.getTime() + refreshTokenValidity * 1000); |
There was a problem hiding this comment.
Refresh token의 만료시간이랑 access token의 만료시간이 같으면, refresh를 못하지 않을까요? access token으로 통신하다가 access token이 만료되면, refresh token을 써서 갱신하는 방식일 것 같은데요 ...
f-lab-lyan
reviewed
Jan 8, 2025
|
|
||
| public TokenResponseDto() {} | ||
|
|
||
| public TokenResponseDto(String accessToken, String refreshToken) { |
f-lab-lyan
reviewed
Jan 8, 2025
| } | ||
|
|
||
| public TokenResponseDto refreshAccessToken(String refreshToken) { | ||
| JwtToken stored = jwtTokenRepository.findByToken(refreshToken) |
There was a problem hiding this comment.
오 .... refreshtoken을 저장해야하는 이유는 무엇인가요?
f-lab-lyan
reviewed
Jan 8, 2025
|
|
||
| @Service | ||
| public class JwtService { | ||
| private final UserRepository userRepository; |
There was a problem hiding this comment.
하나의 서비스가 서로 다른 서비스의 repository를 가지는 것에 대해서 멘토링 시간에 얘기해보죠. :-)
f-lab-lyan
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JWT 설정