Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#15] 업비트 API 데이터 db 저장 #16

Merged
merged 5 commits into from
Jan 23, 2025
Merged

[#15] 업비트 API 데이터 db 저장 #16

merged 5 commits into from
Jan 23, 2025

Conversation

austinhong22
Copy link
Collaborator

웹소켓 연결 후 DB 저장

  • transaction 도메인 변경
  • 유저 임계값 필터링, 관리자 임계값 필터링 서비스
  • 웹소켓을 통해 api 연결 후 임계값 이상의 데이터 db 저장

@austinhong22 austinhong22 self-assigned this Jan 15, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

return userAlertRepository.save(alert);
}

public List<UserAlert> getAllAlerts() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 API대신에 Pagination에 대한 고민이 필요할 것 같습니다.

Copy link

@f-lab-lyan f-lab-lyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드는 이해했습니다. 다만, 구조적으로 비효율적인 부분에 대해서는 개선이 필요할 것 같네요. 수고하셨습니다. 👍

@austinhong22 austinhong22 changed the base branch from feature/12 to develop January 15, 2025 14:43
@austinhong22 austinhong22 merged commit 63818ee into develop Jan 23, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants