[#31] Telegram Bot 기본 연동 및 회원가입 기능 구현 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
f-lab-lyan
reviewed
Feb 18, 2025
|
|
||
| // 사용자의 이메일을 받아 OTP를 생성 후 텔레그램으로 전송 | ||
| @PostMapping("/request-otp") | ||
| public String requestOtp(@RequestBody Map<String, String> request) { |
There was a problem hiding this comment.
리턴 타입을 전부 동일하게 맞추는 것이 좋을 것 같습니다. 그래서 이 메소드도 클래스로 감싸서 결과를 내보내면 좋을 것 같네요.
f-lab-lyan
reviewed
Feb 18, 2025
| private String password; | ||
|
|
||
| private Long telegramChatId; | ||
| private String otpHash; |
There was a problem hiding this comment.
이 필드는 일회용일테니, 필요하다면, 캐쉬같은 곳에 저장하면 좋을 것 같네요.
f-lab-lyan
reviewed
Feb 18, 2025
| } | ||
|
|
||
| @Override | ||
| public void onUpdateReceived(Update update) { |
There was a problem hiding this comment.
멀티 인스턴스 환경에서 어떻게 동작하는지 확인해보시면 좋을 것 같아요.
f-lab-lyan
reviewed
Feb 18, 2025
| private final UserService userService; | ||
| private final TelegramBotProperties telegramBotProperties; | ||
|
|
||
| private Map<Long, RegistrationData> registrationDataMap = new HashMap<>(); |
There was a problem hiding this comment.
다중 인스턴스 환경에 맞춰서 이 내용은 DB에 저장해야하지 않을까요? 혹은 캐쉬에 저장하거나
f-lab-lyan
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telegram Bot 기본 연동 및 회원가입 기능 구현