Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#35] Kafka Producer 설정 #36

Merged
merged 2 commits into from
Feb 18, 2025
Merged

[#35] Kafka Producer 설정 #36

merged 2 commits into from
Feb 18, 2025

Conversation

austinhong22
Copy link
Collaborator

@austinhong22 austinhong22 commented Feb 17, 2025

Kafka Producer 설정

  • docker-compose-kafka 설정
  • KafkaProducer 설정
  • TransactionService 카프카 적용

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
17.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@austinhong22 austinhong22 self-assigned this Feb 17, 2025
@austinhong22 austinhong22 changed the title [# [#35] Kafka Producer 설정 Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose.yml과 합치는 것이 좋지 않을까요?

@@ -36,10 +43,19 @@ public Transaction getTransactionById(int id) {
}

public Transaction createTransaction(Transaction tx) {
long start = System.currentTimeMillis();
Transaction savedTx = transactionRepository.save(tx);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디비 저장도 카프카에 맡겨보면 어떨까 싶네요.

Copy link

@f-lab-lyan f-lab-lyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카프카 설정은 잘 된 것 같네요. 😄

@austinhong22 austinhong22 changed the base branch from feature/22 to develop February 18, 2025 16:25
@austinhong22 austinhong22 merged commit a6ec4d8 into develop Feb 18, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants