Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#44] useralert 변경 #45

Merged
merged 5 commits into from
Mar 4, 2025
Merged

[#44] useralert 변경 #45

merged 5 commits into from
Mar 4, 2025

Conversation

austinhong22
Copy link
Collaborator

useralert 변경

  • ask_bid, chatId 추가
  • alert 메시지 형식 변경

@austinhong22 austinhong22 requested a review from f-lab-lyan March 3, 2025 17:26
@austinhong22 austinhong22 self-assigned this Mar 3, 2025
Copy link

sonarqubecloud bot commented Mar 3, 2025

@@ -51,22 +51,30 @@ public void consume(ConsumerRecord<String, TransactionEventDto> record, Acknowle
for (AlertSetting setting : alertSettings) {
if (event.getTradeVolume() >= setting.getThreshold()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 로직은 쿼리로 옮기는 게 더 효율적일 것 같네요.

event.getCoin(),
event.getTradePrice(),
event.getAskBid()
);
telegramWebhookUserBot.sendTextMessage(chatId, message);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{Cahced|Fixed}ThreadPool.submit(....);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분을 메세지 큐로 바꾸면 좋을 것 같습니다.

@austinhong22 austinhong22 changed the base branch from feature/26 to develop March 4, 2025 15:12
@austinhong22 austinhong22 merged commit 6ae390a into develop Mar 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants