[feat][#1] 사용자 관련 API 구현 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 15, 2025 17:18
f-lab-plam
approved these changes
Feb 24, 2025
Comment on lines
+12
to
+13
| @ExceptionHandler(BaseException.class) | ||
| public ResponseEntity<ErrorResponse> handleBaseException(BaseException ex) { |
There was a problem hiding this comment.
👍👍👍 exception 처리 아주 좋네요. 나중에 기능들 세분화 되면서 더 발전된 처리과정 되는걸 기대합니다!
Comment on lines
+80
to
+91
| public List<UserResponseDTO> findAllUsers() { | ||
| return userRepository.findAll() | ||
| .stream() | ||
| .map(UserResponseDTO::new) | ||
| .toList(); | ||
| } | ||
|
|
||
| public UserResponseDTO findUserById(Long id) { | ||
| UserEntity user = userRepository.findById(id) | ||
| .orElseThrow(UserNotFoundException::new); | ||
| return new UserResponseDTO(user); | ||
| } |
There was a problem hiding this comment.
해당 메서드들은 @Transactional(readOnly = true) 를 붙이지 않은 이유가 있나요?
위쪽 조회 메서드는 붙어있는데, 해당 메서드들은 @Transactional(readOnly = true) 의 트레이드 오프를 생각하시고 빼신걸까요?
There was a problem hiding this comment.
단일 엔티티 조회라서 readOnly 속성을 제거하려고 했었는데, 제대로 확인하지 못했습니다. 제거하고 다시 올리겠습니다!
Comment on lines
+18
to
+26
| @Override | ||
| public UserDetails loadUserByUsername(String email) throws UsernameNotFoundException { | ||
| UserEntity userEntity = userRepository.findByEmail(email) | ||
| .orElseThrow(() -> new UsernameNotFoundException("유저를 찾을 수 없습니다.")); | ||
|
|
||
| if (!userEntity.isActive()) { | ||
| throw new UsernameNotFoundException("비활성화된 계정입니다. 관리자에게 문의하세요."); | ||
| } | ||
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
resolve : #1
작업 내용
참고사항
회원 삭제 방식 변경
회원 삭제 시
PATCH메서드를 사용해서isActive필드를 업데이트하도록 변경하였습니다.1.1. PATCH 메서드 선택 이유
- 기존에는
DELETE메서드를 사용할지 고민했으나, 회원 데이터를 완전히 삭제하는 대신 비활성화하는 방식을 적용하기 위해PATCH메서드를 선택하였습니다.- 이를 통해 회원 데이터를 유지하면서 복구가 가능하도록 하였습니다.
1.2. 비활성화된 회원 처리 방식
-
isActive = false상태인 사용자는 로그인 등 주요 기능이 제한됩니다.