Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore ui test #55

Merged
merged 2 commits into from
Jan 31, 2025
Merged

explore ui test #55

merged 2 commits into from
Jan 31, 2025

Conversation

Guri999
Copy link
Collaborator

@Guri999 Guri999 commented Jan 26, 2025

πŸ“μž‘μ—… λ‚΄μš©

explore ν™”λ©΄ UI ν…ŒμŠ€νŠΈ
νŒ¨λŸ¬λ―Έν„° 따라 λ³€ν˜•λ˜λŠ” 경둜 ν…μŠ€νŠΈλ‘œ λ³€ν™˜ ν›„ ν‘œμ‹œ
폴더 & 파일 ui ν‘œμ‹œ
파일 ν΄λ¦­μ‹œ 이벀트 λ°œμƒ 검사

@Guri999 Guri999 self-assigned this Jan 26, 2025
Copy link

Test Results

0 tests   -β€Š21   0 βœ…  -β€Š21   0s ⏱️ -15s
0 suites  -β€Šβ€‡9   0 πŸ’€ ± 0 
0 files    -β€Šβ€‡9   0 ❌ ± 0 

Results for commit e9989ca. ± Comparison against base commit d318721.

tint = Color.Unspecified
)

Column(
modifier = Modifier
.clearAndSetSemantics { },
modifier = Modifier,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 ModifierλŠ” ν•„μš”ν•œκ°€μš”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accessibility ν–₯상을 μœ„ν•΄ contentDecription을 λ¬Άμ–΄μ£Όλ €κ³  semanticsλ₯Ό μ΄ˆκΈ°ν™” ν–ˆμ—ˆλŠ”λ°μš”
κ·Έλ ‡κ²Œ λ˜λ‹ˆκΉŒ ν…ŒμŠ€νŠΈ μ½”λ“œμ—μ„œ onNodeWithText 찾지λ₯Ό λͺ»ν•˜λ”λΌκ΅¬μš”, λ‹€λ₯Έ 해결방법을 찾지 λͺ»ν•΄ μ§€μ› λŠ”λ° Modifierλ§ŒμžˆλŠ” 것도 μ§€μš°κ² μŠ΅λ‹ˆλ‹€

verticalArrangement = Arrangement.spacedBy(4.dp)
) {
Text(
modifier = Modifier
.clearAndSetSemantics { },
modifier = Modifier,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

text = name,
style = Theme.typography.body2sb,
color = Theme.colors.text
)
Text(
modifier = Modifier
.clearAndSetSemantics { },
modifier = Modifier,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@get: Rule
val composeTestRule = createComposeRule()
private val fakeUiState: MutableState<ExploreUiState> =
mutableStateOf(ExploreUiState.INIT)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ€„λ°”κΏˆν•œ μ΄μœ κ°€ μžˆμ„κΉŒμš”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„ˆλ¬΄ κΈΈμ–΄ λ³΄μ˜€μŠ΅λ‹ˆλ‹€

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅, μ€„λ°”κΏˆ 등은 μ–Έμ–΄λ§ˆλ‹€ μ œκ³΅λ˜λŠ” κΈ°λ³Έ μ»¨λ²€μ…˜μ΄λ‚˜ IDEμ—μ„œ μ œκ³΅ν•˜λŠ” μ½”λ“œ μ •λ ¬ 도ꡬλ₯Ό μ‚¬μš©ν•˜λ©΄ 일관적인 μŠ€νƒ€μΌμ„ μœ μ§€ν•  수 μžˆμŠ΅λ‹ˆλ‹€. λ°”κΎΈμ‹€ ν•„μš”λŠ” μ—†κ³  참고만 ν•΄μ£Όμ„Έμš”.

mutableStateOf(ExploreUiState.INIT)

private val fakeHandleIntent: MutableState<(ExploreUiIntent) -> Unit> =
mutableStateOf({})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link

@f-lab-dean f-lab-dean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
μ½”λ©˜νŠΈ ν™•μΈν•˜μ‹œκ³  λ¨Έμ§€ν•΄μ£Όμ„Έμš”.

@Guri999 Guri999 merged commit 74a6f72 into dev Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants