fix(list): block unauthorized to reorder the workitem

fabric8-ui · Mar 27, 2017 · a9d63be · a9d63be
1 parent 7295a25
commit a9d63be
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/app/toolbar-panel/toolbar-panel.component.html b/src/app/toolbar-panel/toolbar-panel.component.html
@@ -32,7 +32,7 @@
             Move
             <span class="caret"></span>
           </button>
-          <ul role="menu" aria-labelledby="wi_filter_dropdown" class="btn-move" dropdownMenu>
+          <ul role="menu" aria-labelledby="wi_filter_dropdown" class="btn-move" *ngIf="loggedIn" dropdownMenu>
             <li>
               <a role="menuitem" tabindex="-1" (click)="moveItem('top')">Move to Top</a>
             </li>

diff --git a/src/app/work-item/work-item-list/work-item-list-entry/work-item-list-entry.component.html b/src/app/work-item/work-item-list/work-item-list-entry/work-item-list-entry.component.html
@@ -6,7 +6,7 @@
 </div>
 <div class="workItemList_entry" (click)="onSelect($event)">
 	<!--checkbox to select a WI and move it-->
-	<div class="row-cbh" title="Select the checkbox to move the item.">
+	<div class="row-cbh" title="Select the checkbox to move the item." *ngIf="loggedIn">
 		<input type="checkbox" [checked]="checkedWI" (click)="toggleEntry($event)" />
 	</div>
 	<!-- info area -->

diff --git a/src/app/work-item/work-item-list/work-item-list.component.ts b/src/app/work-item/work-item-list/work-item-list.component.ts
@@ -77,7 +77,7 @@ export class WorkItemListComponent implements OnInit, AfterViewInit, DoCheck {
 
   // See: https://angular2-tree.readme.io/docs/options
   treeListOptions = {
-    allowDrag: true,
+    allowDrag: false,
     getChildren: (node: TreeNode): any => {
       return this.workItemService.getChildren(node.data);
     },
@@ -104,6 +104,9 @@ export class WorkItemListComponent implements OnInit, AfterViewInit, DoCheck {
     this.loggedIn = this.auth.isLoggedIn();
     // console.log('ALL USER DATA', this.route.snapshot.data['allusers']);
     // console.log('AUTH USER DATA', this.route.snapshot.data['authuser']);
+    if(this.loggedIn) {
+      this.treeListOptions['allowDrag'] = true;
+    }
     this.spaceSubscription = this.spaces.current.subscribe(space => {
       if (space) {
         console.log('[WorkItemListComponent] New Space selected: ' + space.attributes.name);
@@ -237,6 +240,7 @@ export class WorkItemListComponent implements OnInit, AfterViewInit, DoCheck {
       .subscribe(message => {
         this.loggedIn = false;
         this.authUser = null;
+        this.treeListOptions['allowDrag'] = false;
     });
     //Filters like assign to me should stack with the current filters
     this.broadcaster.on<string>('item_filter')