Move input constructor logic to GenNode
#3378
Open
+468
−539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69619733 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 14, 2025
Summary: Pull Request resolved: facebook#3378 Differential Revision: D69619733
lena-kashtelyan
force-pushed
the
export-D69619733
branch
from
9bf2ef7 to
bcf95d9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69619733 |
lena-kashtelyan
force-pushed
the
export-D69619733
branch
from
bcf95d9 to
e0c9fa8
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#3378 Differential Revision: D69619733
|
This pull request was exported from Phabricator. Differential Revision: D69619733 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#3378 Differential Revision: D69619733
lena-kashtelyan
force-pushed
the
export-D69619733
branch
from
e0c9fa8 to
dfb1add
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69619733 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#3378 Differential Revision: D69619733
lena-kashtelyan
force-pushed
the
export-D69619733
branch
from
dfb1add to
6559a84
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 28, 2025
Summary: Pull Request resolved: facebook#3378 Differential Revision: D69619733
lena-kashtelyan
force-pushed
the
export-D69619733
branch
from
6559a84 to
fb928f0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69619733 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3378 +/- ##
=======================================
Coverage 95.99% 96.00%
=======================================
Files 539 539
Lines 52874 52860 -14
=======================================
- Hits 50757 50748 -9
+ Misses 2117 2112 -5 ☔ View full report in Codecov by Sentry. |
added 2 commits
February 28, 2025 08:31
…ncommitted/untracked changes) Differential Revision: D67319697
Differential Revision: D68790218
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 28, 2025
Summary: Pull Request resolved: facebook#3378 Reviewed By: saitcakmak, mgarrard Differential Revision: D69619733
lena-kashtelyan
force-pushed
the
export-D69619733
branch
from
fb928f0 to
ec85978
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69619733 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 28, 2025
Summary: Pull Request resolved: facebook#3378 Reviewed By: saitcakmak, mgarrard Differential Revision: D69619733
lena-kashtelyan
force-pushed
the
export-D69619733
branch
2 times, most recently
from
cd07db8 to
c84753e
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 28, 2025
Summary: Pull Request resolved: facebook#3378 Reviewed By: saitcakmak, mgarrard Differential Revision: D69619733
Summary: Pull Request resolved: facebook#3378 Reviewed By: saitcakmak, mgarrard Differential Revision: D69619733
|
This pull request was exported from Phabricator. Differential Revision: D69619733 |
lena-kashtelyan
force-pushed
the
export-D69619733
branch
from
c84753e to
ce18c60
Compare
lena-kashtelyan
added a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 1, 2025
Summary: Pull Request resolved: facebook#3378 Differential Revision: D69619733 Reviewed By: saitcakmak, mgarrard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D69619733