add apk file paths in backup sosource logging

Summary: print the `mZipSources` path list in Backup soSource. Reviewed By: adicatana Differential Revision: D56665839 fbshipit-source-id: d37665c7169890656b13e5ab100046adeb366f35
facebook · Apr 29, 2024 · dc3fbfc · dc3fbfc
1 parent d9bd759
commit dc3fbfc
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 2 deletions.
diff --git a/java/com/facebook/soloader/BackupSoSource.java b/java/com/facebook/soloader/BackupSoSource.java
@@ -189,4 +189,25 @@ public SoSource recover(Context context) {
     }
     return recovered;
   }
+
+  @Override
+  public String toString() {
+    String path;
+    try {
+      path = String.valueOf(soDirectory.getCanonicalPath());
+    } catch (IOException e) {
+      path = soDirectory.getName();
+    }
+
+    return new StringBuilder()
+        .append(getName())
+        .append("[root = ")
+        .append(path)
+        .append(" flags = ")
+        .append(flags)
+        .append(" apks = ")
+        .append(mZipSources.toString())
+        .append("]")
+        .toString();
+  }
 }
diff --git a/java/com/facebook/soloader/ExtractFromZipSoSource.java b/java/com/facebook/soloader/ExtractFromZipSoSource.java
@@ -216,4 +216,13 @@ public int hashCode() {
       return 31 * result + backingEntry.hashCode();
     }
   }
+
+  @Override
+  public String toString() {
+    try {
+      return mZipFileName.getCanonicalPath();
+    } catch (IOException e) {
+      return mZipFileName.getName();
+    }
+  }
 }
diff --git a/java/com/facebook/soloader/SoLoader.java b/java/com/facebook/soloader/SoLoader.java
@@ -388,7 +388,7 @@ private static void initSoSources(Context context, int flags) throws IOException
       SoSource[] finalSoSources = soSources.toArray(new SoSource[soSources.size()]);
       int prepareFlags = makePrepareFlags();
       for (int i = finalSoSources.length; i-- > 0; ) {
-        LogUtil.d(TAG, "Preparing SO source: " + finalSoSources[i]);
+        LogUtil.i(TAG, "Preparing SO source: " + finalSoSources[i]);
 
         if (SYSTRACE_LIBRARY_LOADING) {
           Api18TraceUtils.beginTraceSection(TAG, "_", finalSoSources[i].getClass().getSimpleName());
@@ -400,7 +400,7 @@ private static void initSoSources(Context context, int flags) throws IOException
       }
       sSoSources = finalSoSources;
       sSoSourcesVersion.getAndIncrement();
-      LogUtil.d(TAG, "init finish: " + sSoSources.length + " SO sources prepared");
+      LogUtil.i(TAG, "init finish: " + sSoSources.length + " SO sources prepared");
     } finally {
       sSoSourcesLock.writeLock().unlock();
     }