Skip to content

Commit

Permalink
separate out banks api tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@aryzle
aryzle committed Dec 28, 2024
1 parent f04a799 commit 84f584c
Show file tree
Hide file tree
Showing 2 changed files with 206 additions and 193 deletions.
193 changes: 0 additions & 193 deletions hasher-matcher-actioner/src/OpenMediaMatch/tests/test_api.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
from OpenMediaMatch.tests.utils import (
app,
client,
create_bank,
add_hash_to_bank,
IMAGE_URL_TO_PDQ,
)
from OpenMediaMatch.background_tasks.build_index import build_all_indices
from OpenMediaMatch.persistence import get_storage
Expand All @@ -34,196 +31,6 @@ def test_status_response(client: FlaskClient):
assert response.data == b"I-AM-ALIVE"


def test_banks_empty_index(client: FlaskClient):
response = client.get("/c/banks")
assert response.status_code == 200
assert response.json == []


def test_banks_create(client: FlaskClient):
# Must not start with number
post_response = client.post(
"/c/banks",
json={"name": "01_TEST_BANK"},
)
assert post_response.status_code == 400

# Cannot contain lowercase letters
post_response = client.post(
"/c/banks",
json={"name": "my_test_bank"},
)
assert post_response.status_code == 400

post_response = client.post(
"/c/banks",
json={"name": "MY_TEST_BANK_01"},
)
assert post_response.status_code == 201
assert post_response.json == {
"matching_enabled_ratio": 1.0,
"name": "MY_TEST_BANK_01",
}

# Should now be visible on index
response = client.get("/c/banks")
assert response.status_code == 200
assert response.json == [post_response.json]


def test_banks_update(client: FlaskClient):
post_response = client.post(
"/c/banks",
json={"name": "MY_TEST_BANK"},
)
assert post_response.status_code == 201

# check name validation
post_response = client.put(
"/c/bank/MY_TEST_BANK",
json={"name": "1_invalid_name"},
)
assert post_response.status_code == 400

# check update with rename
post_response = client.put(
"/c/bank/MY_TEST_BANK",
json={"name": "MY_TEST_BANK_RENAMED"},
)
assert post_response.status_code == 200
assert post_response.get_json()["name"] == "MY_TEST_BANK_RENAMED"

# check update without rename
post_response = client.put(
"/c/bank/MY_TEST_BANK_RENAMED",
json={"enabled": False},
)
assert post_response.status_code == 200
assert post_response.get_json()["matching_enabled_ratio"] == 0

# check update without ratio
post_response = client.put(
"/c/bank/MY_TEST_BANK_RENAMED",
json={"enabled_ratio": 0.5},
)
assert post_response.status_code == 200
assert post_response.get_json()["matching_enabled_ratio"] == 0.5

# Final test to make sure we only have one bank with proper name and disabled

get_response = client.get("/c/banks")
assert get_response.status_code == 200
json = get_response.get_json()
assert len(json) == 1
assert json[0] == {"name": "MY_TEST_BANK_RENAMED", "matching_enabled_ratio": 0.5}


def test_banks_delete(client: FlaskClient):
post_response = client.post(
"/c/banks",
json={"name": "MY_TEST_BANK"},
)
assert post_response.status_code == 201

# check name validation
post_response = client.delete(
"/c/bank/MY_TEST_BANK",
)
assert post_response.status_code == 200

# deleting non existing bank should succeed
post_response = client.delete(
"/c/bank/MY_TEST_BANK",
)
assert post_response.status_code == 200


def test_banks_add_hash(client: FlaskClient):
bank_name = "NEW_BANK"
create_bank(client, bank_name)

image_url = "https://github.com/facebook/ThreatExchange/blob/main/pdq/data/bridge-mods/aaa-orig.jpg?raw=true"

post_response = client.post(
f"/c/bank/{bank_name}/content?url={image_url}&content_type=photo"
)

assert post_response.status_code == 200, str(post_response.get_json())
assert post_response.json == {
"id": 1,
"signals": {
"pdq": "f8f8f0cee0f4a84f06370a22038f63f0b36e2ed596621e1d33e6b39c4e9c9b22"
},
}


def test_banks_delete_hash(client: FlaskClient):
bank_name = "NEW_BANK"
image_url = "https://github.com/facebook/ThreatExchange/blob/main/pdq/data/bridge-mods/aaa-orig.jpg?raw=true"

create_bank(client, bank_name)
add_hash_to_bank(client, bank_name, image_url, 1)

post_response = client.delete(f"/c/bank/{bank_name}/content/1")

assert post_response.status_code == 200
assert post_response.json == {"deleted": 1}


def test_banks_add_metadata(client: FlaskClient):
bank_name = "NEW_BANK"
create_bank(client, bank_name)

image_url = "https://github.com/facebook/ThreatExchange/blob/main/pdq/data/bridge-mods/aaa-orig.jpg?raw=true"
post_request = f"/c/bank/{bank_name}/content?url={image_url}&content_type=photo"

post_response = client.post(
post_request, json={"metadata": {"invalid_metadata": 5}}
)
assert post_response.status_code == 400, str(post_response.get_json())

post_response = client.post(
post_request,
json={"metadata": {"content_id": "1197433091", "json": {"asdf": {}}}},
)

assert post_response.status_code == 200, str(post_response.get_json())


def test_banks_add_hash_index(app: Flask, client: FlaskClient):
bank_name = "NEW_BANK"
bank_name_2 = "NEW_BANK_2"
image_url = "https://github.com/facebook/ThreatExchange/blob/main/pdq/data/bridge-mods/aaa-orig.jpg?raw=true"
image_url_2 = "https://github.com/facebook/ThreatExchange/blob/main/pdq/data/misc-images/c.png?raw=true"

# Make two banks and add images to each bank
create_bank(client, bank_name)
add_hash_to_bank(client, bank_name, image_url, 1)
create_bank(client, bank_name_2)
add_hash_to_bank(client, bank_name, image_url_2, 2)

storage = get_storage()
# ensure index is empty to start with
assert storage.get_signal_type_index(PdqSignal) is None

# Build index
build_all_indices(storage, storage, storage)

# Test against first image
post_response = client.get(
f"/m/raw_lookup?signal_type=pdq&signal={IMAGE_URL_TO_PDQ[image_url]}"
)
assert post_response.status_code == 200
assert post_response.json == {"matches": [1]}

# Test against second image
post_response = client.get(
f"/m/raw_lookup?signal_type=pdq&signal={IMAGE_URL_TO_PDQ[image_url_2]}"
)
assert post_response.status_code == 200
assert post_response.json == {"matches": [2]}


def test_lookup_success(app: Flask, client: FlaskClient):
storage = get_storage()
# ensure index is empty to start with
Expand Down
Loading

0 comments on commit 84f584c

Please sign in to comment.