Return 200 even if exchange doesn't exist for deletes

facebook · Jan 31, 2025 · 91db4f2 · 91db4f2
1 parent df92ef5
commit 91db4f2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/hasher-matcher-actioner/src/OpenMediaMatch/blueprints/curation.py b/hasher-matcher-actioner/src/OpenMediaMatch/blueprints/curation.py
@@ -441,10 +441,6 @@ def exchange_delete(exchange_name: str):
     }
     """
     storage = persistence.get_storage()
-    collab = storage.exchange_get(exchange_name)
-    if collab is None:
-        abort(404, f"exchange '{exchange_name}' not found")
-
     storage.exchange_delete(exchange_name)
     return {"message": "Exchange deleted"}
 

diff --git a/hasher-matcher-actioner/src/OpenMediaMatch/tests/test_api.py b/hasher-matcher-actioner/src/OpenMediaMatch/tests/test_api.py
@@ -169,9 +169,8 @@ def test_exchange_delete(app: Flask, client: FlaskClient):
     delete_response = client.delete(
         "/c/exchange/TEST_EXCHANGE",
     )
-    # test exchange not found
-    assert delete_response.status_code == 404
-    assert delete_response.get_json()["message"] == "exchange 'TEST_EXCHANGE' not found"
+    # deleting an exchange that doesn't exist returns 200
+    assert delete_response.status_code == 200
 
     # create an exchange
     post_response = client.post(
@@ -180,7 +179,7 @@ def test_exchange_delete(app: Flask, client: FlaskClient):
     )
     assert post_response.status_code == 201
 
-    # test a successful delete
+    # test a real delete
     delete_response = client.delete(
         "/c/exchange/FOO_EXCHANGE",
     )