lint fb_syslog; delete uncontrolled files #208
Conversation
jaymzh
requested review from
joshuamiller01,
NaomiReeves,
scottruss and
davide125
jaymzh
changed the title
| directory '/etc/rsyslog.d' do | ||
| action :delete | ||
| recursive true | ||
| notifies :restart, "service[#{service_name}]" | ||
| end | ||
|
|
There was a problem hiding this comment.
Can you spin this out in a separate PR ? I just checked and we still have a bunch of crap in there so it'd need a careful rollout.
There was a problem hiding this comment.
Alternatively, gate it behind an attribute knob
Signed-off-by: Phil Dibowitz <[email protected]>
|
@davide125 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| 'authlog' => { | ||
| 'comment' => 'Log all auth stuff', | ||
| 'selector' => 'auth,authpriv.*', | ||
| 'action' => '/var/log/auth.log', | ||
| }, |
There was a problem hiding this comment.
This is a Debian thing, so it should probably be gated to Debian/Ubuntu, CentOS and friends use /var/log/secure for this stuff.
There was a problem hiding this comment.
well it should probably just have the right name on RHEL and friends. Not having the auth/secure logs is a bummer. Will do a conditional.
|
@jaymzh has updated the pull request. You must reimport the pull request before landing. |
|
@jaymzh has updated the pull request. You must reimport the pull request before landing. |
|
@davide125 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
No description provided.