Skip to content

Commit

Permalink
Add duration_ms percentiles
Browse files Browse the repository at this point in the history
Summary:
[This note](https://fb.workplace.com/notes/340378350526665/) shows how a quantile stat can be defined.  I'm moving `accounting.duration_ms*` over to this so we get quantiles for "free".

I can't figure out how to stop generating the all time percentiles.  I don't think they're useful and could be misleading in the future.

Differential Revision: D68840920

fbshipit-source-id: 1684783e7ec52afbce28f60bcb3147b3da873e64
  • Loading branch information
John Oxley authored and facebook-github-bot committed Feb 13, 2025
1 parent 5b17c49 commit 63a227b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions fb303/ExportType.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ struct QuantileConsts {
static constexpr const std::array<double, 2> kP0_P100{{.0, 1}};
static constexpr const std::array<double, 4> kP25_P50_P75_P95{
{.25, 0.5, 0.75, 0.95}};
static constexpr const std::array<double, 5> kP25_P50_P75_P95_P99{
{.25, 0.5, 0.75, 0.95, 0.99}};
};

struct SlidingWindowPeriodConsts {
Expand Down

0 comments on commit 63a227b

Please sign in to comment.