Delete global profile dumping API

Summary: We would like to eliminate global APIs on HermesRuntime, so remove this newly added API since it isn't currently in use. Reviewed By: hoxyq Differential Revision: D69508799 fbshipit-source-id: 5be841a417a7c8e4abc1611cdb2668f00b003b55
facebook · Feb 14, 2025 · da5aabc · da5aabc
1 parent 91354c6
commit da5aabc
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 33 deletions.
diff --git a/API/hermes/hermes.cpp b/API/hermes/hermes.cpp
@@ -1211,15 +1211,6 @@ sampling_profiler::Profile HermesRuntimeImpl::dumpSampledTraceToProfile() {
 #endif // HERMESVM_SAMPLING_PROFILER_AVAILABLE
 }
 
-std::vector<sampling_profiler::Profile>
-HermesRuntime::dumpSampledTraceToProfilesGlobal() {
-#if HERMESVM_SAMPLING_PROFILER_AVAILABLE
-  return ::hermes::vm::SamplingProfiler::dumpAsProfilesGlobal();
-#else
-  throwHermesNotCompiledWithSamplingProfilerSupport();
-#endif // HERMESVM_SAMPLING_PROFILER_AVAILABLE
-}
-
 /*static*/ std::unordered_map<std::string, std::vector<std::string>>
 HermesRuntime::getExecutedFunctions() {
   std::unordered_map<

diff --git a/API/hermes/hermes.h b/API/hermes/hermes.h
@@ -88,11 +88,6 @@ class HERMES_EXPORT HermesRuntime : public jsi::Runtime {
   /// Dump sampled stack trace to the given stream.
   static void dumpSampledTraceToStream(std::ostream &stream);
 
-  /// Dump sampled stack trace for all registered local sampling profiler
-  /// instances to a data structure that can be used by third parties.
-  static std::vector<sampling_profiler::Profile>
-  dumpSampledTraceToProfilesGlobal();
-
   /// Return the executed JavaScript function info.
   /// This information holds the segmentID, Virtualoffset and sourceURL.
   /// This information is needed specifically to be able to symbolicate non-CJS

diff --git a/include/hermes/VM/Profiler/SamplingProfiler.h b/include/hermes/VM/Profiler/SamplingProfiler.h
@@ -286,11 +286,6 @@ class SamplingProfiler {
   /// Static wrapper for dumpChromeTrace.
   static void dumpChromeTraceGlobal(llvh::raw_ostream &OS);
 
-  /// Static wrapper for dumpAsProfile. Will dump in separate Profile for each
-  /// local sampling profiler instance.
-  static std::vector<facebook::hermes::sampling_profiler::Profile>
-  dumpAsProfilesGlobal();
-
   /// Enable and start profiling.
   static bool enable(double meanHzFreq = 100);
 

diff --git a/lib/VM/Profiler/SamplingProfiler.cpp b/lib/VM/Profiler/SamplingProfiler.cpp
@@ -208,20 +208,6 @@ void SamplingProfiler::serializeInDevToolsFormat(llvh::raw_ostream &OS) {
   clear();
 }
 
-std::vector<facebook::hermes::sampling_profiler::Profile>
-SamplingProfiler::dumpAsProfilesGlobal() {
-  auto globalProfiler = sampling_profiler::Sampler::get();
-  std::lock_guard<std::mutex> lk(globalProfiler->profilerLock_);
-
-  std::vector<facebook::hermes::sampling_profiler::Profile> profiles;
-  for (auto *currentProfilerInstance : globalProfiler->profilers_) {
-    auto profileForCurrentInstance = currentProfilerInstance->dumpAsProfile();
-    profiles.push_back(std::move(profileForCurrentInstance));
-  }
-
-  return profiles;
-}
-
 facebook::hermes::sampling_profiler::Profile SamplingProfiler::dumpAsProfile() {
   std::lock_guard<std::mutex> lk(runtimeDataLock_);