[Breaking Change][lexical-playground]: Refactor: Remove special case for collapsible forward deletion #7204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ivailop7
previously approved these changes
Feb 18, 2025
|
Looks like there's probably a webkit-specific issue to handle, will take a look today |
ivailop7
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have more robust handling of deleteCharacter around decorators and shadow roots, we can get rid of the expectation that CollapsibleContainerNode does something weird. AFAICT this behavior was a result of the implementation and not something that was specifically intended?
Follow-up to #7155
Related #3082 #4257 https://github.com/facebook/lexical/blame/f5e6329c3773a3e968eeb06a50ae002ce8b1318f/packages/lexical-playground/src/plugins/CollapsiblePlugin/index.ts#L169
Closes #7203
Test plan
Before
Delete forward before a CollapsibleNode would pierce the shadow root and unroll its content at the caret
After
Delete forward before a CollapsibleNode will do nothing, like other shadow roots (e.g. table)