[lexical-link] Bug Fix: Remove anchors with empty href during DOM import #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdivyansh
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
reviewed
Feb 22, 2025
There was a problem hiding this comment.
I'm not sure this is the best place to encode this normalization, it's easy enough to do this in editor html.import configuration or with a LinkNode transform if it's something that's appropriate for your editor. It looks like this was an intentional decision to allow empty links rather than to normalize them away #3194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
LinkNodeallows importing DOM with an emptyhref. However, IMO, it doesn't make sense during HTML paste.Test plan
Before
Screen.Recording.2025-02-22.at.12.14.11.AM.mov
After
Screen.Recording.2025-02-22.at.12.12.47.AM.mov