[@lexical/code] Feature: export SerializedCodeHighlightNode
#7254
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniGuardiola
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
reviewed
Feb 26, 2025
There was a problem hiding this comment.
This isn't sufficient to actually use it outside of this package, you'd also have to export from the entrypoint (index.ts).
In the meantime you should be able to use ReturnType<CodeHighlightNode['exportJSON']> to refer to this value. It might make more sense to use a generic type in your application like type JSONForNode<T extends LexicalNode> = ReturnType<T['exportJSON']> instead of trying to make sure every declared serialization type is exported.
ivailop7
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Export
SerializedCodeHighlightNodesince it's helpful to consumers.Test plan
n/a