Fix watcher path normalisation with Windows and Watchman #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67700720 |
Summary: Despite increasing timeouts for this test a few times, we still see failures both in OSS and internal CI. I'm pretty sure there's a race condition in both our own `FallbackWatcher` / `NodeWatcher` *and* Watchman where when recursively watching a subtree, new files are added before a directory is watched or crawled, and so we never see an event for them. This is a problem, but I don't want to entirely lose the signal for this important set of tests due to that flakiness. This skips the problematic test on Windows and Linux until we have a better fix. We haven't observed a problem on macOS IIRC. Changelog: Internal Reviewed By: huntie Differential Revision: D67712965
Summary: Fixes an issue with the Watchman watcher backend on Windows where emitted posix-style paths were not properly normalised, leading to inconsistencies with other watchers and broken tests. Adds the necessary normalisation and reenables tests. Changelog: Internal (This is luckily corrected downstream by the use of `path.join` on `relativePath`, which performs normalisation, so there was no observable bug here, it was just fragile.) Reviewed By: huntie Differential Revision: D67700720
facebook-github-bot
force-pushed
the
export-D67700720
branch
from
91b0925 to
8691226
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67700720 |
|
This pull request has been merged in dd3e56c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes an issue with the Watchman watcher backend on Windows where emitted posix-style paths were not properly normalised, leading to inconsistencies with other watchers and broken tests.
Adds the necessary normalisation and reenables tests.
Changelog: Internal
(This is luckily corrected downstream by the use of
path.joinonrelativePath, which performs normalisation, so there was no observable bug here, it was just fragile.)Reviewed By: huntie
Differential Revision: D67700720