[React 19] When submitting a form action multiple times, requestFormReset throws the TypeError 'Cannot read null property (reading 'queue')'.

[sujipark-fe]

Summary

Related Previous Issues: #30041
Related Previous PR: #30365

There was already a PR raised, but I wrote a PR to be more specific and prevent type errors.

When passing an asynchronous function to a

action, if you pass that action again before receiving the response, the stateHook.next value will be null in the ensureFormComponentIsStateful function running inside the requestFormReset function, resulting in a type error. To prevent this problem, I modified the ensureFormComponentIsStateful function to maintain the current statefull state if the stateHook.next value is null.

Test Code

function App() {
  const formAction = async () => {
    await new Promise((resolve) => setTimeout(resolve, 3000));
  };
  return (
    <form action={formAction}>
      <input type="text" name="name" />
      <input type="submit" />
    </form>
  );
}
export default App;

Test Step

1. Enter any text in input text.
2. Submit.
3. Submit multiple times within 3 seconds (setTimeout time).
   (usually after 2-3 seconds, just before the response comes)

How did you test this change?

• codesandbox: https://codesandbox.io/p/sandbox/react-19-form-reset-error-l79dq5
• React Version: 19.0.0-rc-5c56b873-20241107
• local test and yarn test.
  

If there is anything wrong, please tell me.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 11, 2024 3:39pm

[facebook-github-bot]

Hi @charmmming7!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!