Make OptimizeResourcesPass.disallowed_types() less dangerous #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Suppose this configuration option was used to broadly disallow removals of types that can have references (i.e. drawables). This would do the wrong thing as implemented currently. Treat such configured types as roots so they get traversed for references. Reviewed By: thezhangwei Differential Revision: D70284056
|
This pull request was exported from Phabricator. Differential Revision: D70284056 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
Summary: Pull Request resolved: #909 Suppose this configuration option was used to broadly disallow removals of types that can have references (i.e. drawables). This would do the wrong thing as implemented currently. Treat such configured types as roots so they get traversed for references. Reviewed By: thezhangwei Differential Revision: D70284056 fbshipit-source-id: 85623a14f08839c445a4088790d30eef6f4f84dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Suppose this configuration option was used to broadly disallow removals of types that can have references (i.e. drawables). This would do the wrong thing as implemented currently. Treat such configured types as roots so they get traversed for references.
Reviewed By: thezhangwei
Differential Revision: D70284056