Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolver function type assertions for TypeScript #4742

Open
captbaritone opened this issue Jul 15, 2024 · 0 comments
Open

Add resolver function type assertions for TypeScript #4742

captbaritone opened this issue Jul 15, 2024 · 0 comments

Comments

@captbaritone
Copy link
Contributor

captbaritone commented Jul 15, 2024

In order for Resolvers to be fully features in TypeScript we need to ensure the compiler produces type assertions for them in the same way that type assertions are generated for Flow.

Right now there are a few places where the compiler has TODO comments and does not emit helpful types for TypeScript:

For testing you can find resolver tests cases in the Flow tests here and copy them into the TypeScript tests directory.

Note that after adding new fixture files you'll need to regenerate the Rust tests that pull in those fixture tests. More info here.

Related: We'll also need to remove the @ts-nocheck from generated TypeScript files. We'll track that in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant