Add test for memtable bloom filter with WriteBufferManager #13398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ... to ensure proper cache charging. However, this is a somewhat hazardous combination if there are many CFs and could be the target of future work. Test Plan: this is the test
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
reviewed
Feb 19, 2025
|
|
||
| // Just the start of a memtable, no Bloom, rounded up to kSizeDummyEntry | ||
| ASSERT_GE(cache->GetUsage(), 1024U); | ||
| ASSERT_LE(cache->GetUsage(), 256U * 1024U); |
There was a problem hiding this comment.
nit: use static constexpr std::size_t kSizeDummyEntry = CacheReservationManagerImplCacheEntryRole::kMisc::GetDummyEntrySize(); ? Same for upper bound below just so it's easier to sea how many kSizeDummyEntry in the upper bound
hx235
reviewed
Feb 19, 2025
| ASSERT_OK(Put("foo2", "bar2")); | ||
|
|
||
| // Expecting a memtable Bloom of ratio times write_buffer_size, memory tracked | ||
| ASSERT_GE(cache->GetUsage(), 1000000U); |
There was a problem hiding this comment.
nit: options.write_buffer_size * options.memtable_prefix_bloom_size_ratio instead of hard-coded 1000000U ? Same for 2000000U below
hx235
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: ... to ensure proper cache charging. However, this is a somewhat hazardous combination if there are many CFs and could be the target of future work.
Test Plan: this is the test