Minify compiled style keys #875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
2 tasks
nmn
reviewed
Jan 30, 2025
necolas
commented
Feb 3, 2025
| @@ -374,7 +374,7 @@ describe('Evaluation of imported values works based on configuration', () => { | |||
| _inject2("@property ----__hashed_var__1jqb1tb { syntax: \\"*\\"; inherits: false;}", 0); | |||
| const styles = { | |||
| color: color => [{ | |||
| "--__hashed_var__1jqb1tb": color == null ? null : "__hashed_var__b69i2g", | |||
| kUBWw5: "__hashed_var__b69i2g", | |||
There was a problem hiding this comment.
Regression for dynamic styles
|
Updated to use a new feature flag for controlling this behavior - |
Reduce the size of minifed JS by "minifying" the compiled style keys produced by StyleX. This patch uses a base 62 hashing function to generate smaller hashes, which are prefixed with `k` to avoid requiring quotes around hashes that start with a number.
Avoid false positives on code contained within inline babel snapshots
nmn
approved these changes
Feb 27, 2025
|
I still need to figure out why the dynamic styles output changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
Reduce the size of minifed JS by "minifying" the compiled style keys produced by StyleX. This patch uses a base 62 hashing function to generate smaller hashes, which are prefixed with
kto avoid requiring quotes around hashes that start with a number.Fix #741
Pre-flight checklist
Contribution Guidelines