Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert npm ci #907

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix: revert npm ci #907

merged 1 commit into from
Feb 27, 2025

Conversation

mellyeliu
Copy link
Member

@mellyeliu mellyeliu commented Feb 27, 2025

What changed / motivation ?

Vercel builds seem to be erroring with #906, let's switch back to debug. package-lock.js in main may be in a weird state

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2025
Copy link

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/[email protected] size:compare
./size-compare.js /tmp/tmp.OJpux1UdaN /tmp/tmp.1MSFeIHX29

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 985 985 1.00
· minified 3,154 3,154 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 567,170 567,170 1.00
· minified 10,232,457 10,232,457 1.00
rollup-example/.build/stylex.css
· compressed 100,609 100,609 1.00
· minified 755,721 755,721 1.00

@mellyeliu mellyeliu merged commit ff8b926 into main Feb 27, 2025
8 of 9 checks passed
@mellyeliu mellyeliu changed the title chore: revert npm ci fix: revert npm ci Feb 27, 2025
@necolas
Copy link
Contributor

necolas commented Feb 27, 2025

postinstall might not run after ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants