Improve monorepo task workflows #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
necolas
force-pushed
the
refactor-workflows-and-tasks
branch
from
4519b77 to
9890f5a
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
necolas
force-pushed
the
refactor-workflows-and-tasks
branch
from
9890f5a to
dfcbaa9
Compare
|
The "size" benchmark only fails because the base commit doesn't have the new benchmarks package. If you inspect the job you can see that the "patch" step ran successfully. After this lands, future PRs will collect benchmark data correctly |
necolas
force-pushed
the
refactor-workflows-and-tasks
branch
from
dfcbaa9 to
6e4cb7b
Compare
mellyeliu
approved these changes
Feb 28, 2025
* Faster task and CI builds by excluding 'app' workspace builds. * Faster code formatting by excluding large fixtures. * Automatic precommit checks for format and lint errors. * 'npm test' runs all the same tests as the CI workflow. * Minor reorganization of workflow jobs.
necolas
force-pushed
the
refactor-workflows-and-tasks
branch
from
6e4cb7b to
64397c7
Compare
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm testruns the same tests (locally) as the CI workflow.Fixes #878