yoga::Node::getStyle() to yoga::Node::style()
#1555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D52803393 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 16, 2024
Summary: X-link: facebook/react-native#42314 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
NickGerleman
force-pushed
the
export-D52803393
branch
from
c937e46 to
84e0020
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 16, 2024
Summary: X-link: facebook/yoga#1555 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
|
This pull request was exported from Phabricator. Differential Revision: D52803393 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 16, 2024
Summary: X-link: facebook/react-native#42314 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
NickGerleman
force-pushed
the
export-D52803393
branch
from
84e0020 to
57d348f
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 16, 2024
Summary: X-link: facebook/yoga#1555 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
|
This pull request was exported from Phabricator. Differential Revision: D52803393 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/yoga#1555 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
NickGerleman
force-pushed
the
export-D52803393
branch
from
57d348f to
e65b246
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/react-native#42314 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
|
This pull request was exported from Phabricator. Differential Revision: D52803393 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/react-native#42314 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
NickGerleman
force-pushed
the
export-D52803393
branch
from
e65b246 to
e72e0f9
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/yoga#1555 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
|
This pull request was exported from Phabricator. Differential Revision: D52803393 |
Summary: X-link: facebook/react-native#42314 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
NickGerleman
force-pushed
the
export-D52803393
branch
from
e72e0f9 to
d56a2ba
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/yoga#1555 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393
|
This pull request was exported from Phabricator. Differential Revision: D52803393 |
|
This pull request has been merged in 35b9b52. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/react-native#42314 X-link: facebook/yoga#1555 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393 fbshipit-source-id: 557df34a9f0fb0ee42ad23b1fda99c1e0eb1d4e3
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: #42314 X-link: facebook/yoga#1555 The next diff moves a bunch of methods to `yoga::Style`. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters. Changelog: [Internal] Reviewed By: rozele Differential Revision: D52803393 fbshipit-source-id: 557df34a9f0fb0ee42ad23b1fda99c1e0eb1d4e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The next diff moves a bunch of methods to
yoga::Style. This renames the function to be a tad bit shorter, for more readable callsites. It also makes it more consistent with style property getters.Changelog: [Internal]
Reviewed By: rozele
Differential Revision: D52803393