Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Disable tests that cause time-outs on newer versions of Mac OSX. #1140

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

hermanventer
Copy link
Contributor

Description

Some complicated tests that used to pass now fail on systems with less memory (as well as system with seemingly enough memory, but running newer versions of OsX than the CI systems.

Disabling these tests make for a better experience for people building MIRAI and running it on their own systems. For example see #1130.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

ran ./validate.sh on my local laptop

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2022
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #1140 (cc4abe7) into main (4fe7492) will increase coverage by 0%.
The diff coverage is 74%.

@@          Coverage Diff          @@
##            main   #1140   +/-   ##
=====================================
  Coverage     77%     77%           
=====================================
  Files         23      23           
  Lines      16086   16051   -35     
=====================================
- Hits       12499   12486   -13     
+ Misses      3587    3565   -22     
Impacted Files Coverage Δ
checker/src/constant_domain.rs 58% <ø> (+<1%) ⬆️
checker/src/crate_visitor.rs 74% <44%> (+<1%) ⬆️
checker/src/call_visitor.rs 81% <61%> (+<1%) ⬆️
checker/src/block_visitor.rs 80% <65%> (+1%) ⬆️
checker/src/options.rs 78% <74%> (+<1%) ⬆️
checker/src/body_visitor.rs 88% <78%> (-1%) ⬇️
checker/src/type_visitor.rs 74% <85%> (-1%) ⬇️
checker/src/utils.rs 86% <100%> (+<1%) ⬆️
checker/src/interval_domain.rs 82% <0%> (-3%) ⬇️
checker/src/summaries.rs 74% <0%> (-1%) ⬇️
... and 9 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@hermanventer hermanventer merged commit 099a317 into main Mar 21, 2022
@hermanventer hermanventer deleted the test_failures branch March 21, 2022 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants