-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix pymomentum link error on macOS (#115)
Summary: Fix pymomentum link error by replacing `Python::Python` to `Python::Module` ## Checklist: - [x] Adheres to the [style guidelines](https://facebookincubator.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Pull Request resolved: #115 Test Plan: ``` pixi r test pixi r test_pymomentum ``` Reviewed By: yutingye Differential Revision: D64991401 Pulled By: jeongseok-meta fbshipit-source-id: be5026543e8df71622f36105c4260626c9403ba3
- Loading branch information
1 parent
d8d9481
commit fdc25fe
Showing
7 changed files
with
30 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,24 +44,19 @@ jobs: | |
pixi run cmake --build momentum/examples/hello_world/build | ||
pymomentum: | ||
name: pymomentum-${{ matrix.platform }} | ||
name: pymomentum-${{ matrix.os == 'macos-latest-large' && 'mac-x86_64' || 'mac-arm64' }} | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
include: | ||
- os: macos-latest | ||
platform: mac-arm | ||
- os: macos-latest-large | ||
platform: mac-intel | ||
os: [macos-latest, macos-latest-large] | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Set up pixi | ||
uses: prefix-dev/[email protected] | ||
with: | ||
cache: true | ||
- name: Build PyMomentum | ||
# TODO: Change to test_pymomentum once segfault on import is fixed | ||
- name: Build and test PyMomentum | ||
run: | | ||
pixi run build_pymomentum | ||
pixi run test_pymomentum |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
# python | ||
*.egg-info/ | ||
*.cpython-*.so | ||
*.pyc | ||
|
||
# build artifacts | ||
build/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters