Special linalg.solve fn #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
added 3 commits
March 1, 2024 20:09
|
Hmm would switching to a more "friendly" scattering matrix formulation avoid the issue? The condition number for the example given was indeed pretty bad... but I wonder if we'd have similar issues if we used, for example, the convention described in Rumpf et al? |
|
That could be, but I am not so optimistic. I do think that changing the PML could improve things, as called for in #99. That might be a better fix than the approach in this PR, since this PR is in some sense performance-suboptimal and will result in a larger program. For this reason I have no plan to actually merge this change. In the context of PML improvement, one could specifically look for the condition number of these matrices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jax-ml/jax#20047
This Jax issue seems to manifest in problematic scattering matrices in some situations.