Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding abi3-py38 compatibility for python wheel #6

Merged
merged 2 commits into from
Jan 31, 2025
+4 −2
Merged

adding abi3-py38 compatibility for python wheel #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce49eee
adding abi3 feature to pyo3
luccabb Jan 30, 2025
c863e96
adding abi3 py38 compatibility
luccabb Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ nvml-wrapper = "0.10.0"
blake3 = "1.5.4"
clap = { version = "4.5.19", features = ["derive"] }
anyhow = "1.0.89"
pyo3 = { version = "0.23.3", features = ["extension-module"], optional = true }
# 'abi3' feature enables Python modules to be used against multiple Python versions
# see: https://pyo3.rs/v0.13.2/building_and_distribution.html#py_limited_apiabi3
pyo3 = { version = "0.23.3", features = ["extension-module", "abi3-py38"], optional = true }
cxx = { version = "1.0", optional = true }
cc = { version = "1.0", optional = true }

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ version = "0.1.2"
dependencies = ["cffi"]
readme = "src/python/README.md"
description = "Library to create a GPU Node ID"
requires-python = ">=3.10"
requires-python = ">=3.8"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you want to downgrade here?
The default version in fbcode is 3.10 https://fburl.com/wiki/7q6e07my

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a result of "abi3-py38" it should be compatible with any version >= python 3.8. so removed the artificial restriction on pyproject.toml

license = {file = "LICENSE"}
authors = [
{email = "[email protected]"},
Expand Down