chore: configure eslint to enforce promise rules

.eslintrc

@@ -23,6 +23,7 @@
   },
   "rules": {
     "space-before-function-paren": 0,
-    "import/export": 0
+    "import/export": 0,
+    "promise/catch-or-return": "error"
   }
 }

lib/server.js

@@ -30,7 +30,7 @@ export class Http3Server extends Http3WebTransport {
     /** @type {Record<string, ReadableStream>} */
     this.sessionStreams = {}
 
-    /** @type {Record<string, ReadableStreamController<Http3WTSession>>} */
+    /** @type {Record<string, ReadableStreamDefaultController<Http3WTSession>>} */
     this.sessionController = {}
 
     this.port = null
@@ -101,7 +101,9 @@ export class Http3Server extends Http3WebTransport {
         this.sessionController[path] = controller
       }
     })
-    if (!args || !args.noAutoPaths) this.transportInt.addPath(path)
+    if (!args || !args.noAutoPaths) {
+      this.transportInt.addPath(path)
+    }
     return this.sessionStreams[path]
   }
 
@@ -111,17 +113,19 @@ export class Http3Server extends Http3WebTransport {
   onSessionRequest(args) {
     if (args.promise && args.header) {
       if (!this.requestHandler) throw new Error('Request handler not set')
-      this.requestHandler({ header: args.header }).then(
-        (/** @type {any} */ result) => {
+      this.requestHandler({ header: args.header })
+        .then((/** @type {any} */ result) => {
           log('oSR', result)
           this.transportInt.finishSessionRequest({
             promise: args.promise,
             header: args.header,
             session: args.session,
             ...result
           })
-        }
-      )
+        })
+        .catch((/** @type {any} */ err) => {
+          log.error(err)
+        })
     } else throw new Error('onSessionRequest')
   }
 

lib/stream.js

@@ -94,10 +94,14 @@ export class Http3WTStream {
               this.pendingoperation = new Promise((resolve, reject) => {
                 this.pendingres = resolve
               })
-              const dataprom = this.parentobj.waitForDatagramsSend()
-              dataprom.finally(() => {
-                this.objint.writeChunk(chunk)
-              })
+              this.parentobj
+                .waitForDatagramsSend()
+                .finally(() => {
+                  this.objint.writeChunk(chunk)
+                })
+                .catch((/** @type {any} */ err) => {
+                  log.error(err)
+                })
               return this.pendingoperation
             } else {
               log.trace('chunk info:', chunk)

lib/webtransport.js

@@ -45,6 +45,7 @@ export class WebTransport {
 
     this.datagrams = sessionint.datagrams
 
+    /** @type {ReadableStream<WebTransportBidirectionalStream>} */
     this.incomingBidirectionalStreams = sessionint.incomingBidirectionalStreams
 
     this.incomingUnidirectionalStreams =

test/datagrams.spec.js

@@ -44,6 +44,7 @@ describe('datagrams', function () {
     let closed = false
 
     // write datagrams until the server receives one and closes the connection
+    // eslint-disable-next-line promise/catch-or-return
     Promise.resolve().then(async () => {
       // eslint-disable-next-line no-unmodified-loop-condition
       while (!closed) {

test/fixtures/read-stream.js

@@ -1,3 +1,8 @@
+/**
+ * @template T
+ * @typedef {import('node:stream/web').ReadableStream<T>} ReadableStream<T>
+ */
+
 /**
  * Read a stream contents to the end and return it
  *

test/fixtures/reader-value.js

@@ -1,3 +1,8 @@
+/**
+ * @template T
+ * @typedef {import('node:stream/web').ReadableStream<T>} ReadableStream<T>
+ */
+
 /**
  * @template T
  * @param {ReadableStream<T>} readableStream