Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develco VOC Sensor Support #313

Conversation

schrodingersket
Copy link
Contributor

Completes #284

Note that the new Climax/Develco clusters are NOT added to any coordinator endpoints by default; this pull request only adds support for them to be optionally added. Once cluster instances are shared across multiple endpoints for various manufacturers, these manufacturer-specific clusters should be added to endpoints unique to Climax and Develco to maintain better code modularity (see #310 ).

Additionally, new macros have been added to zcl_options.h in order to conditionally register manufacturer endpoints; all previous endpoints are enabled, so this PR introduces zero change in current functionality.

…endpoints. Added `ZCL_ENDPOINT_REG_*` variables to `zcl_options.h` to allow configurable extra endpoint registration.
…Climax CO2 Concentration and PM2.5 Measurement clusters.
sensors. Note that these clusters are currently disabled, but are
supported.
@schrodingersket schrodingersket force-pushed the feature/develco-voc-sensor branch from 0f0ca7b to f58c4a1 Compare July 9, 2020 17:06
@pipiche38
Copy link

I think @badzz submitted a PR which remove the restriction on Manufacturer Specific. In such all Manufacturer Specific are now accepted.
In addition if a message/command is not handle by the firmware, the message is send to the above layer (plugin for example) via the Data Indication 0x8002 to be process.

@schrodingersket
Copy link
Contributor Author

I think @badzz submitted a PR which remove the restriction on Manufacturer Specific. In such all Manufacturer Specific are now accepted.
In addition if a message/command is not handle by the firmware, the message is send to the above layer (plugin for example) via the Data Indication 0x8002 to be process.

I'm not sure how I never saw this update, but since there's no restriction on Manufacturer Specific clusters and other messages are passed to the host, I will close this issue pull request and corresponding issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants