Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 마이페이지 #149

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: 마이페이지 #149

wants to merge 4 commits into from

Conversation

Hajin-Lee0406
Copy link
Contributor

@Hajin-Lee0406 Hajin-Lee0406 commented Apr 30, 2024

무엇을 위한 PR인가요?(: 뒤 설명추가)

  • 신규 기능 추가 : 작성한 post 목록 조회, 좋아요 누른 post 목록 조회 api
  • 버그 수정 :
  • 리펙토링 : 유저 정보 조회 api 수정
  • 문서 업데이트 :
  • 기타 :

작업 내역

  • 유저 정보 조회 api
    • 속한 모든 가족에 대한 갯수로 변경
    • 누른 좋아요 갯수도 확인 가능
  • 작성한 post 목록 조회 api
  • 좋아요 누른 post 목록 조회 api

Copy link
Member

@sonshn sonshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 이해하기 쉬운 static 변수 쓰는 것 너무 좋은 것 같아요!

@@ -82,7 +95,7 @@ public PostUserRes createUser(PostUserReq.joinUser postUserReq, MultipartFile pr

// TODO: BirthDate -> String에서 LocalDateTime으로 변환
String strBirthDate = postUserReq.getStrBirthDate();
DateTimeFormatter dateTimeFormatter = DateTimeFormatter.ofPattern("yyyyMMdd");
DateTimeFormatter dateTimeFormatter = DateTimeFormatter.ofPattern(BIRTH_FORMAT_PATTERN);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 좋은 방법 같아요! 감사합니다! 👍

@@ -63,4 +61,17 @@ public void delete() {
public void updateStatus(Status status) {
this.status = status;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대신 추가해주셨네요 😭 PostService 쪽에 있는 중복함수는 삭제하도록 하겠습니다...ㅠㅠ

@serak0310 serak0310 requested a review from zzo3ozz May 14, 2024 02:29
Copy link
Member

@zzo3ozz zzo3ozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 👍저도 DateFormat 관련 부분 배워갑니다!

Copy link
Contributor

@spacewalk00 spacewalk00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 ! 고생하셨습니다 👍

Copy link
Contributor

@serak0310 serak0310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~ 수고하셨습니다~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants