feat: 실시간 채팅 - 기본 메세지 송수신, 세션 처리 #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GETTER가 누락되어 builder 패턴이 원하는 대로 실행되지 않음
…eature/chatting-session # Conflicts: # .idea/.gitignore # .idea/deployment.xml
…eature/chatting-session
Hajin-Lee0406
approved these changes
Jun 19, 2024
| @NotNull | ||
| private String message; | ||
| @NotNull | ||
| private LocalDateTime sendedTime; |
There was a problem hiding this comment.
response도 validtion 사용하신 이유 궁금합니다!
There was a problem hiding this comment.
response라는 생각을 안하고 관성적으로 작성한듯 합니다!! 수정하겠습니다!!!!
| @@ -5,23 +5,39 @@ | |||
| import org.springframework.stereotype.Service; | |||
| import org.springframework.transaction.annotation.Transactional; | |||
|
|
|||
| import java.util.Set; | |||
| import java.util.concurrent.TimeUnit; | |||
|
|
|||
| @Service | |||
| @Transactional(readOnly = true) | |||
There was a problem hiding this comment.
해당 부분 제가 작성한 부분이 아니라서 잘 모르겠습니다만, 제 생각에는 불필요한 것 같긴 합니다!
@spacewalk00 융 확인해주실 수 있으실까요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
무엇을 위한 PR인가요?(: 뒤 설명추가)
작업 내역
문서의 양이 PR 페이지에 담기에 길어 Notion 페이지로 대체합니다.
FamilyMoments Chat Service 개요문서에서 실시간 채팅 서비스에 대한 기본적인 개요 및 개발 내용을 확인하실 수 있고,Spring 실시간 채팅 개발 과정문서에서WebSocket,STOMP등의 보충 설명을 확인하실 수 있습니다.🏷️ FamilyMoments Chat Service 개요
🏷️ Spring 실시간 채팅 개발 과정
PR 특이 사항
현재 PR 병합 후 추가 PR 작성하도록 하겠습니다!
PR 병합 이후 각 파일을 아래 패키지에 추가 부탁드립니다!
ChatRedisPrefix.java-com.spring.familymoments.domain.chat내부StompWebSocketConfig.java-com.spring.familymoments.config.secret내부