FAI-14886 | GitHub - Fix SAML SSO error when processing gql paginated response #1898
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbruno21
requested review from
cjwooo,
ypc-faros and
willmarks
as code owners
|
dbruno21
changed the title
ypc-faros
approved these changes
Jan 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GraphQL paginate plugin for octokit has a crashing bug when processing a response with nulls / undefined that's returned by the API instead of a proper response with empty nodes.
Updated code to handle pagination manually.
Type of change
Related issues
Migration notes
Extra info