feat: Add Bun and Deno to typescript support check #408
Conversation
There was a problem hiding this comment.
Currently we do not support Bun or Deno on Fastify.
Frankly, we have not time, and I would not accept a PR without tests either.
https://github.com/fastify/fastify/blob/main/docs/Reference/LTS.md#long-term-support
Codex-
force-pushed
the
typescript_runtime_bun_deno
branch
from
2c0b43d to
5a6d882
Compare
While I understand that is the official stance, as noted in your link, with all of the other supported tooling already included would it really do any harm to simply allow this check to pass for these runtimes?
You beat me to it, I amended my commit with the bun tests I intended to push originally :) Fastify is simply incompatible with Deno currently, I'm happy to include another test run file to run against deno but it will fail and not add value |
scripts/unit.js
Outdated
|
|
||
| const child = exec('npm run unit:with-modules') | ||
| const child = exec(argv[2] + ' run unit:with-modules') |
There was a problem hiding this comment.
Can you please add npm as a default?
You'd need to add bun to CI as well.
There was a problem hiding this comment.
Sure can
I was going to ask actually, so the CI currently uses that shared workflow from the workflows repo, so to not muddy concerns in that workflow, would you be happy with an additional job added to the ci.yml that performs the tests for bun?
jobs:
test:
uses: fastify/workflows/.github/workflows/[email protected]
with:
license-check: true
lint: true
bun:
uses: ...There was a problem hiding this comment.
Went with adding a job to the existing workflow for now, the erroneously published version aplha takes precedence over alpha in string ordering so until it reaches beta the workflow needs to specifically install the version required for tests to satisfy the semver usage (since semver doesn't recognise aplha as a valid version)
Codex-
force-pushed
the
typescript_runtime_bun_deno
branch
from
348d44e to
150fafa
Compare
.github/workflows/ci.yml
Outdated
| # The erraneous typod version `5.0.0-aplha` takes priority over .3 as 'p' > 'l' | ||
| run: | | ||
| bun i --ignore-scripts | ||
| bun i -D --ignore-scripts [email protected] |
There was a problem hiding this comment.
This is not ideal
The typod version seems to be unpublished now — can't find it at https://www.npmjs.com/package/fastify?activeTab=versions
Can you try removing the line?
| bun i -D --ignore-scripts [email protected] |
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm sorry but I don't understand why this is needed.
There was a problem hiding this comment.
Because of the typo in the version name bun takes p as being of a higher version than l when parsing aplha
aplha.1 does not pass the tests
Can be removed once beta has begun
There was a problem hiding this comment.
I can confirm this is the case
|
Please merge, this is the only problem I have faced regarding bun support in fastify. |
Signed-off-by: Gürgün Dayıoğlu <[email protected]>
|
Resolved the conflict but it's failing now, I'll check why when I get home |
This change allows the Bun and Deno runtimes to use this loader with Fastify base without erroring as seen in #317.
Tests
Node
No regressions, everything passing.
Bun
bun run typescript✅bun run typescript:jest✅bun run typescript:vitest✅bun run unit✅unit.jsupdated to consume an arg for the runtimetest/typescript/basic.tscannot be run as a particular function Tap uses has not yet been implemented in BunNotImplementedError: node:v8 Serializer is not yet implemented in Bun.Deno
deno task typescript✅ServerResponseas a class, while node a function, which causes this error in Fastify.Class constructor ServerResponse cannot be invoked without 'new'deno task typescript:jest❌deno task typescript:vitest❌deno task unit❌While it has already been communicated that Fastify is not actively supporting either Bun or Deno runtimes, despite the results, it would be great to see this check updated to allow their usage at a "ymmv" degree.
Fixes #317
Checklist
npm run testdocumentation is changed or addedand the Code of conduct