fix: prevent premature close error #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmanm
force-pushed
the
custom-err-handler
branch
2 times, most recently
from
88dbb0e to
cfad3b5
Compare
mcollina
reviewed
Oct 15, 2020
test/static.test.js
Outdated
| fastify.errorHandler = (_, __, reply) => { | ||
| reply.send('default-error-obj') | ||
| } | ||
| } |
There was a problem hiding this comment.
You should also add a test where fastify.errorHandler is undefined.
salmanm
force-pushed
the
custom-err-handler
branch
2 times, most recently
from
bd4caaf to
d296b94
Compare
|
Implemented feedbacks on this PR, but build is still not green until fastify/light-my-request#102 is merged and version is bumped. |
salmanm
force-pushed
the
custom-err-handler
branch
from
d296b94 to
cc76dd0
Compare
|
Thank you, @salmanm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in fastify/fastify#2616 & #116, the module fails and logs an error when client closes the request prematurely. This PR fixes that by adding a custom
errorHandlerin the route config so that the specificERR_STREAM_PREMATURE_CLOSEcan be handled in a special way. For all other errors, we still fallback to the defaultfastify.errorHandlerwhich was introduced in 3.7.0.Checklist
npm run testandnpm run benchmarkand the Code of conduct