Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add logLevel option #502

Merged
merged 11 commits into from
Feb 2, 2025
Merged

feat: add logLevel option #502

merged 11 commits into from
Feb 2, 2025

Conversation

Jacopo47
Copy link
Contributor

@Jacopo47 Jacopo47 commented Jan 13, 2025 •
edited
Loading

Closes #494

Checklist

@Jacopo47 Jacopo47 mentioned this pull request Jan 13, 2025
Closed
2 tasks
mcollina
mcollina approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested review from Fdawgs and gurgunday January 13, 2025 12:16
Fdawgs
Fdawgs reviewed Jan 13, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Fdawgs
Update README.md
835c6f4 
Signed-off-by: Frazer Smith <[email protected]>
@Fdawgs Fdawgs changed the title feat: add support to logLevel option feat: add logLevel option Jan 13, 2025
gurgunday
gurgunday reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint is failing, otherwise lgtm

Eomm
Eomm reviewed Jan 18, 2025
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THe issue is that the code uses tap but we are no longer using it:
#495

The test/static.test.js file in this PR needs to be updated accordingly

@Jacopo47
Copy link
Contributor Author

Thanks for the hint @Eomm !
In the past days I didn't had the time to dig into it.
I'll try to submit the fix asap

@Eomm Eomm merged commit bcf294f into fastify:master Feb 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs left review comments

@gurgunday gurgunday gurgunday left review comments

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for logLevel plugin's option
5 participants
@Jacopo47 @mcollina @Eomm @Fdawgs @gurgunday