Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 6 #936

Merged
merged 17 commits into from
May 14, 2021
Merged

Rails 6 #936

merged 17 commits into from
May 14, 2021

Conversation

CloCkWeRX
Copy link
Member

@CloCkWeRX CloCkWeRX commented May 11, 2021 •
edited
Loading

Fixes #842

  • Upgrade to rails 6
  • 2x failing specs
  • Deprecation messages
  • Review new features available
  • Manual regression tests

@CloCkWeRX CloCkWeRX added this to the 0.20.0 milestone May 11, 2021
CloCkWeRX
CloCkWeRX commented May 11, 2021
View reviewed changes
bin/setup
# end

puts "\n== Preparing database =="
system! 'bin/rails db:setup'
system! 'bin/rails db:prepare'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: I have to check this is ok.

CloCkWeRX
CloCkWeRX commented May 11, 2021
View reviewed changes
config/initializers/content_security_policy.rb
@@ -12,6 +12,8 @@
# policy.object_src :none
# policy.script_src :self, :https
# policy.style_src :self, :https
# # If you are using webpack-dev-server then specify webpack-dev-server host
# policy.connect_src :self, :https, "http://localhost:3035", "ws://localhost:3035" if Rails.env.development?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#699 and #770 tried previously to get us over to webpack; it might be worth looking at in a follow up to this one.

@CloCkWeRX
Copy link
Member Author

New features As others have commented, #937 is maybe the most useful part of the rails 6 feature set; outside of the swap to webpack by default.

@CloCkWeRX CloCkWeRX marked this pull request as ready for review May 11, 2021 15:01
@CloCkWeRX
Copy link
Member Author

Ugh, https://dev.to/nuttapon/handle-csrf-issue-when-upgrade-rails-from-5-to-6-1edp will need to be added to our changelog

@johnbumgardner johnbumgardner self-requested a review May 13, 2021 15:16
johnbumgardner
johnbumgardner approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@johnbumgardner johnbumgardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed locally and performed basic CRUD actions. Everything seems to be working as before. No features seem to have broken in upgrading

@CloCkWeRX CloCkWeRX merged commit 46da9b7 into master May 14, 2021
@CloCkWeRX CloCkWeRX deleted the rails6 branch May 14, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbumgardner johnbumgardner johnbumgardner approved these changes

Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

Upgrade to rails 6/6.1
2 participants
@CloCkWeRX @johnbumgardner