Redesign Choclo's API #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now distance functions take the explicit coordinates of the two points instead of two tuples of floats.
Create a new points subpackage: include kernels in a new kernels.py file and the forward modelling functions in forward.py. Add a new constants.py file to store universal constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new
pointsubmodule that hosts kernel functions and forwardmodelling functions for point sources. Add test functions for the new forward
modelling functions and edit the ones for the kernels. Add a
constants.pyfile for hosting the universal constants needed to perform the forward
modelling. Change the parameters of the distance functions: they now take the
coordinates of the points as floats instead of grouped in tuples.
Relevant issues/PRs:
Working towards #10