-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud tests documentation update #898
Conversation
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
===========================================
- Coverage 81.91% 67.19% -14.72%
===========================================
Files 42 45 +3
Lines 5447 5637 +190
===========================================
- Hits 4462 3788 -674
- Misses 985 1849 +864
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
config/modules/cloudonly.conf
Outdated
# Cloud only tests | ||
|
||
# Default built-in tests. | ||
include ${DAQ_LIB}/config/modules/host.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is really intended to be cloud-only, then this shouldn't include the base host tests and remove others. What happens if something else is added into host.conf? Then the logic would end up not being "cloud-only"...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed this to only build core modules and cloud test module
Mostly looks good, just one outstanding comment. Let's try to get this cleaned up and submitted to get it out of the queue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor tweaks -- but feel free to submit after you make them (or if they changes don't make sense you can submit anyway...). Just minor suggestions.
config/modules/cloudonly.conf
Outdated
# Cloud only tests | ||
|
||
build ${DAQ_LIB}/docker/modules | ||
include ${DAQ_LIB}/usi/build.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why USI? That's not cloud oriented... ? Is it because there's some part of the system that always tries to run the USI test, even if not explicitly enabled?
Also, can you just name the file "cloud.conf" -- just keeping in the minimalist spirit of the other files in that directory...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re USI - yes, I'd assumed with switch control being abstracted it was the module used for controlling the virtual switch so assumed it's needed. I'll test without it today and omit if not required
Just tested without USI, and at the moment it needs the USI module to run, so I've left it in the cloud config.
|
SGTM -- just wanted to make sure it was "needed"!
…On Fri, Sep 10, 2021 at 11:35 AM Noureddine ***@***.***> wrote:
Just tested without USI, and at the moment it needs the USI module to run,
so I've left it in the cloud config.
***@***.***:~/daq2/daq$ sudo cmd/run
[sudo] password for nour:
Activating venv
Flattening config from local/system.yaml into inst/config/system.conf
Starting Fri 10 Sep 19:32:25 BST 2021
Clearing previous state...
Activating venv
Flattening config from local/system.yaml into inst/config/system.conf
HEAD is now at 9a1c90fc Merge pull request #3837 from gizmoguy/ci-improvements
HEAD is now at a6c78b5f Revert faucet version
HEAD is now at b56721d FIx minor variable typo
Release version
Cleaning bridge pri...
Cleaning bridge sec...
ovsdb-server is running with pid 21883
ovs-vswitchd is running with pid 21947
No external switch model specified.
Error: No such container: daq-usi
DAQ autostart gcp_cred= cmd/usi
Starting USI in debug mode
Unable to find image 'daqf/usi:latest' locally
docker: Error response from daemon: manifest for daqf/usi:latest not found: manifest unknown: manifest unknown.
See 'docker run --help'.
Unable to find image 'daqf/usi:latest' locally
docker: Error response from daemon: manifest for daqf/usi:latest not found: manifest unknown: manifest unknown.
See 'docker run --help'.
***@***.***:~/daq2/daq$
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#898 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPDYL6QS7RUUTXZP2PWLUBJFYVANCNFSM5AUUDK4Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
A brief update to the cloud tests documentation to describe the steps required to configure the cloud tests module as it stands at present.
I've created issue #897 which describes two changes to the module to make initial configuration easier, which if/when implemented will require a small change to the documentation