Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud tests documentation update #898

Merged
merged 6 commits into from
Sep 10, 2021
Merged

Conversation

noursaidi
Copy link
Collaborator

A brief update to the cloud tests documentation to describe the steps required to configure the cloud tests module as it stands at present.

I've created issue #897 which describes two changes to the module to make initial configuration easier, which if/when implemented will require a small change to the documentation

@noursaidi noursaidi requested review from grafnu and pisuke July 19, 2021 23:09
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #898 (a74fb4e) into master (9e7f987) will decrease coverage by 14.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #898       +/-   ##
===========================================
- Coverage   81.91%   67.19%   -14.72%     
===========================================
  Files          42       45        +3     
  Lines        5447     5637      +190     
===========================================
- Hits         4462     3788      -674     
- Misses        985     1849      +864     
Flag Coverage Δ
ata 62.35% <ø> (-0.82%) ⬇️
aux ?
base ?
dhcp ?
many ?
mud ?
switch ?
topo ?
unit 32.87% <ø> (+2.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/traffic_analyzer.py 0.00% <0.00%> (-89.69%) ⬇️
daq/test_modules/ipaddr_module.py 22.85% <0.00%> (-65.72%) ⬇️
daq/varz_state_collector.py 0.00% <0.00%> (-50.61%) ⬇️
daq/external_gateway.py 58.33% <0.00%> (-41.67%) ⬇️
daq/base_gateway.py 61.71% <0.00%> (-30.64%) ⬇️
daq/topology.py 68.57% <0.00%> (-28.41%) ⬇️
daq/test_modules/external_module.py 72.72% <0.00%> (-24.48%) ⬇️
daq/dhcp_monitor.py 78.00% <0.00%> (-21.00%) ⬇️
daq/host.py 77.64% <0.00%> (-13.77%) ⬇️
daq/runner.py 71.92% <0.00%> (-12.62%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e7f987...a74fb4e. Read the comment docs.

# Cloud only tests

# Default built-in tests.
include ${DAQ_LIB}/config/modules/host.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is really intended to be cloud-only, then this shouldn't include the base host tests and remove others. What happens if something else is added into host.conf? Then the logic would end up not being "cloud-only"...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed this to only build core modules and cloud test module

@grafnu
Copy link
Collaborator

grafnu commented Aug 31, 2021

Mostly looks good, just one outstanding comment. Let's try to get this cleaned up and submitted to get it out of the queue?

Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor tweaks -- but feel free to submit after you make them (or if they changes don't make sense you can submit anyway...). Just minor suggestions.

# Cloud only tests

build ${DAQ_LIB}/docker/modules
include ${DAQ_LIB}/usi/build.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why USI? That's not cloud oriented... ? Is it because there's some part of the system that always tries to run the USI test, even if not explicitly enabled?

Also, can you just name the file "cloud.conf" -- just keeping in the minimalist spirit of the other files in that directory...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re USI - yes, I'd assumed with switch control being abstracted it was the module used for controlling the virtual switch so assumed it's needed. I'll test without it today and omit if not required

@noursaidi
Copy link
Collaborator Author

Just tested without USI, and at the moment it needs the USI module to run, so I've left it in the cloud config.

nour@ubun2:~/daq2/daq$ sudo cmd/run 
[sudo] password for nour: 
Activating venv
Flattening config from local/system.yaml into inst/config/system.conf
Starting Fri 10 Sep 19:32:25 BST 2021
Clearing previous state...
Activating venv
Flattening config from local/system.yaml into inst/config/system.conf
HEAD is now at 9a1c90fc Merge pull request #3837 from gizmoguy/ci-improvements
HEAD is now at a6c78b5f Revert faucet version
HEAD is now at b56721d FIx minor variable typo
Release version
Cleaning bridge pri...
Cleaning bridge sec...
ovsdb-server is running with pid 21883
ovs-vswitchd is running with pid 21947
No external switch model specified.
Error: No such container: daq-usi
DAQ autostart gcp_cred= cmd/usi
Starting USI in debug mode
Unable to find image 'daqf/usi:latest' locally
docker: Error response from daemon: manifest for daqf/usi:latest not found: manifest unknown: manifest unknown.
See 'docker run --help'.
Unable to find image 'daqf/usi:latest' locally
docker: Error response from daemon: manifest for daqf/usi:latest not found: manifest unknown: manifest unknown.
See 'docker run --help'.
nour@ubun2:~/daq2/daq$ 

@grafnu
Copy link
Collaborator

grafnu commented Sep 10, 2021 via email

@noursaidi noursaidi merged commit f2f204d into faucetsdn:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants