Fix Pics Statement Failing Unsupported Properties #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafnu
approved these changes
Feb 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
===========================================
- Coverage 82.14% 32.63% -49.51%
===========================================
Files 47 47
Lines 5769 5769
===========================================
- Hits 4739 1883 -2856
- Misses 1030 3886 +2856
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@grafnu |
|
I don't know how to do that specifically (single file), but if you click
through on the detail of the failure it takes you to a summary page:
https://github.com/faucetsdn/daq/pull/948/checks?check_run_id=5192330626
Looks like there's an entry in .checkstyle.xml that's tripping it up. Not
sure what changed (likely a newer version of stickler checks...)
…On Tue, Feb 15, 2022 at 8:17 AM jhughesbiot ***@***.***> wrote:
@grafnu <https://github.com/grafnu>
Is there any way to get a report of the stickler-ci failure for a single
file? I'd like to get that issue resolved before merging just not seeing
anyway to run the formatting check against a single file and get a report.
—
Reply to this email directly, view it on GitHub
<#948 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD6EN3WPGDMYWN6PN6LU3J4CFANCNFSM5OM3ES7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I think I have a fix for the stickler but would want to get this merged in first so I can get a clean PR going to just address that issue. I can't merge it in since I don't have write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects issue: #886
Properties indicated as not supported, will be shown as SKIPPED in the result. The same will occur if an object is in the pics statement but is not in the device as long as all properties are marked false.
Tested against the most recent device that had this failure present itself to confirm both test builds and real world scenarios. Image included to show how the report and pics statement handle these scenarios.