utilize both numpy 1.26 and 2.0

stable Fedora is on 1.26 while rawhide already has 2.2 we need to support both the function compute_certainty is not used in the CLI codebase but in server we need this to properly build detective in Fedora as an RPM Signed-off-by: Tomas Tomecek <[email protected]>
fedora-copr · Jan 6, 2025 · 2998ed1 · 2998ed1
1 parent 81ad0d1
commit 2998ed1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/logdetective/utils.py b/logdetective/utils.py
@@ -80,6 +80,8 @@ def compute_certainty(probs: List[Dict[str, float] | None]) -> float:
     In this case it's just a matter of applying inverse operation exp.
     Of course that leaves you with a value in range <0, 1> so it needs to be multiplied by 100.
     Simply put, this is the most straightforward way to get the numbers out.
+
+    This function is used in the server codebase.
     """
 
     top_logprobs = [

diff --git a/pyproject.toml b/pyproject.toml
@@ -31,7 +31,9 @@ requests = ">0.2.31"
 llama-cpp-python = ">0.2.56,!=0.2.86"
 drain3 = "^0.9.11"
 huggingface-hub = ">0.23.2"
-numpy = "^1.26.0"
+# rawhide has numpy 2, F40 and F41 are still on 1.26
+# we need to support both versions
+numpy = ">=1.26.0"
 
 [build-system]
 requires = ["poetry-core"]

diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -0,0 +1,10 @@
+import pytest
+from logdetective.utils import compute_certainty
+
+
+@pytest.mark.parametrize("probs",(
+    [{"a": 66.6}],
+    [{"b": 99.9}, {"c": 1.0}]
+))
+def test_compute_certainty(probs):
+    compute_certainty(probs)