Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flake8 hook and checking all files #92

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jpodivin
Copy link
Collaborator

@jpodivin jpodivin commented Dec 2, 2024

No description provided.

Copy link
Collaborator

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very good suggestion!

How about black/ruff - I love using those so we don't need to discuss code formatting :)

@jpodivin
Copy link
Collaborator Author

jpodivin commented Dec 9, 2024

We could do ruff as well. I'm wondering how is the hook integration though. If people wouldn't need to download another binary separately.

* updating hooks
* adding flake8 hook
* checking all files

Signed-off-by: Jiri Podivin <[email protected]>
@jpodivin jpodivin marked this pull request as ready for review December 9, 2024 13:19
@praiskup
Copy link
Member

praiskup commented Jan 8, 2025

I'm wondering how is the hook integration though

Not really related to this particular PR, but we are using ruff using vcs-diff-lint in Copr:
https://github.com/fedora-copr/copr/blob/main/.github/workflows/python-diff-lint.yml#L34-L36

@jpodivin jpodivin merged commit b809581 into fedora-copr:main Jan 8, 2025
3 checks passed
@jpodivin jpodivin deleted the flake8 branch January 8, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants